Use G%Rad_Earth_L in mct and NUOPC cap code #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the two lines where the mct and NUOPC caps were using G%Rad_Earth to instead use G%Rad_Earth_L, and cancelled out the dimensional rescaling factors on these lines that are no longer appropriate. All answers should be bitwise identical, but because this change is to code that is not routinely exercised by testing with MOM6-examples, extra care should be taken in assessing these changes.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #38 +/- ##
=========================================
Coverage 28.96% 28.96%
=========================================
Files 240 240
Lines 71175 71175
=========================================
Hits 20619 20619
Misses 50556 50556 Continue to review full report at Codecov.
|
|
This branch diverges significantly from |
gustavo-marques
approved these changes
Dec 12, 2021
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14351 ✔️ |
marshallward
approved these changes
Dec 14, 2021
This was referenced Jan 29, 2022
Hallberg-NOAA
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the two lines where the mct and NUOPC caps were using G%Rad_Earth to
instead use G%Rad_Earth_L, and cancelled out the dimensional rescaling factors
on these lines that are no longer appropriate. All answers should be bitwise
identical, but because this change is to code that is not routinely exercised by
testing with MOM6-examples, extra care should be taken in assessing these
changes.